branch-4.0: [fix](function) preserve sign for negative sub-hour TIMESTAMPTZ offsets #62823#63052
Open
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Open
branch-4.0: [fix](function) preserve sign for negative sub-hour TIMESTAMPTZ offsets #62823#63052github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
…ts (#62823) ### What problem does this PR solve? Problem Summary: When BE renders TIMESTAMPTZ values, it derives the timezone sign from the truncated hour component. For negative sub-hour offsets such as -00:30, integer division makes the hour component 0, so the renderer emits +00:30 instead of -00:30. This affects both constant-folded expressions and runtime values rendered from table data. Root cause: - Old logic: ```cpp int offset_hours = time_offset / 3600; int offset_mins = (std::abs(time_offset) % 3600) / 60; char sign = offset_hours >= 0 ? '+' : '-'; ``` - For time_offset = -1800, offset_hours becomes 0, so the sign is rendered as +. Fix: - Determine the sign from the original second offset. - Split hour and minute fields from the absolute offset value. - Add a focused UT for -00:30 rendering.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62823