Skip to content

[feature](recycle-bin) support three-phase retention for recycle bin#61504

Draft
xuchenhao wants to merge 4 commits intoapache:masterfrom
HYDCP:recycle-bin-three-phase-retention
Draft

[feature](recycle-bin) support three-phase retention for recycle bin#61504
xuchenhao wants to merge 4 commits intoapache:masterfrom
HYDCP:recycle-bin-three-phase-retention

Conversation

@xuchenhao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@xuchenhao xuchenhao closed this Mar 19, 2026
@xuchenhao xuchenhao reopened this Mar 19, 2026
@xuchenhao xuchenhao marked this pull request as draft March 19, 2026 03:30
@xuchenhao
Copy link
Contributor Author

run buildall

@xuchenhao xuchenhao force-pushed the recycle-bin-three-phase-retention branch from 683ce39 to 82ff193 Compare March 19, 2026 05:34
@xuchenhao
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.63% (1796/2284)
Line Coverage 64.40% (32284/50130)
Region Coverage 65.29% (16166/24760)
Branch Coverage 55.69% (8608/15456)

@xuchenhao
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.63% (1796/2284)
Line Coverage 64.39% (32278/50130)
Region Coverage 65.29% (16166/24760)
Branch Coverage 55.73% (8614/15456)

@doris-robot
Copy link

TPC-H: Total hot run time: 26940 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3b68b8581f12da33a6d1756c65dbfedc2446d049, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17618	4582	4369	4369
q2	q3	10716	838	519	519
q4	4729	357	247	247
q5	8020	1224	1023	1023
q6	212	172	147	147
q7	811	861	664	664
q8	10352	1521	1316	1316
q9	6407	4846	4758	4758
q10	6479	1923	1652	1652
q11	508	246	243	243
q12	748	585	463	463
q13	18079	2936	2195	2195
q14	232	241	218	218
q15	q16	749	753	661	661
q17	741	844	446	446
q18	6354	5463	5228	5228
q19	1190	983	617	617
q20	542	504	390	390
q21	4767	2068	1531	1531
q22	377	345	253	253
Total cold run time: 99631 ms
Total hot run time: 26940 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4729	4739	4609	4609
q2	q3	3865	4347	3807	3807
q4	857	1232	764	764
q5	4098	4383	4349	4349
q6	202	198	152	152
q7	1821	1733	1530	1530
q8	2488	2704	2579	2579
q9	7640	7474	7394	7394
q10	3832	3964	3624	3624
q11	520	442	418	418
q12	480	592	442	442
q13	2933	3224	2345	2345
q14	299	305	269	269
q15	q16	705	757	722	722
q17	1176	1419	1602	1419
q18	7236	6753	6728	6728
q19	901	924	930	924
q20	2106	2127	1981	1981
q21	3978	3473	3334	3334
q22	481	421	368	368
Total cold run time: 50347 ms
Total hot run time: 47758 ms

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 59.72% (43/72) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-DS: Total hot run time: 168453 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3b68b8581f12da33a6d1756c65dbfedc2446d049, data reload: false

query5	4338	639	503	503
query6	337	236	214	214
query7	4218	474	264	264
query8	363	252	234	234
query9	8745	2716	2695	2695
query10	488	362	351	351
query11	6974	5115	4854	4854
query12	187	136	133	133
query13	1292	463	352	352
query14	5612	3666	3429	3429
query14_1	2813	2783	2826	2783
query15	211	192	184	184
query16	967	502	457	457
query17	895	778	630	630
query18	2452	453	364	364
query19	219	218	186	186
query20	133	129	129	129
query21	212	140	107	107
query22	13219	14028	14349	14028
query23	16406	15899	15621	15621
query23_1	15823	15767	15719	15719
query24	7237	1605	1208	1208
query24_1	1239	1220	1222	1220
query25	641	464	409	409
query26	1246	278	143	143
query27	2759	490	297	297
query28	4480	1841	1850	1841
query29	844	570	472	472
query30	297	231	187	187
query31	998	928	877	877
query32	82	69	70	69
query33	506	330	277	277
query34	897	876	523	523
query35	628	670	602	602
query36	1100	1123	952	952
query37	129	99	79	79
query38	2951	2909	2892	2892
query39	843	837	810	810
query39_1	798	800	778	778
query40	234	154	135	135
query41	62	59	59	59
query42	262	254	254	254
query43	236	257	221	221
query44	
query45	198	189	184	184
query46	890	1082	601	601
query47	2122	2175	2086	2086
query48	305	326	232	232
query49	638	459	378	378
query50	683	271	208	208
query51	4042	4073	4049	4049
query52	261	266	260	260
query53	289	337	284	284
query54	308	278	264	264
query55	93	92	83	83
query56	326	339	323	323
query57	1963	1762	1668	1668
query58	288	272	274	272
query59	2755	2987	2770	2770
query60	355	345	330	330
query61	160	156	162	156
query62	652	574	533	533
query63	310	275	277	275
query64	5159	1275	1006	1006
query65	
query66	1453	470	362	362
query67	24176	24222	24170	24170
query68	
query69	397	318	293	293
query70	990	972	962	962
query71	344	310	300	300
query72	2854	2669	2508	2508
query73	546	569	326	326
query74	9636	9575	9411	9411
query75	2872	2744	2458	2458
query76	2295	1022	697	697
query77	369	375	307	307
query78	10933	11167	10413	10413
query79	1129	780	581	581
query80	1375	611	547	547
query81	540	258	222	222
query82	1018	155	120	120
query83	347	263	245	245
query84	298	117	93	93
query85	906	506	452	452
query86	409	310	303	303
query87	3217	3138	2982	2982
query88	3593	2667	2657	2657
query89	434	375	342	342
query90	2043	185	166	166
query91	169	164	139	139
query92	76	75	73	73
query93	947	855	498	498
query94	622	322	300	300
query95	606	341	329	329
query96	652	532	228	228
query97	2463	2491	2397	2397
query98	244	223	223	223
query99	1018	965	923	923
Total cold run time: 249867 ms
Total hot run time: 168453 ms

@xuchenhao
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.63% (1796/2284)
Line Coverage 64.38% (32274/50130)
Region Coverage 65.30% (16169/24760)
Branch Coverage 55.75% (8616/15456)

@doris-robot
Copy link

TPC-H: Total hot run time: 26741 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d48333a722afc2e09527997faa23bc1748136195, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	16860	4491	4314	4314
q2	q3	10366	796	525	525
q4	4703	352	248	248
q5	7620	1206	1019	1019
q6	176	175	148	148
q7	787	853	684	684
q8	9376	1495	1313	1313
q9	4816	4703	4758	4703
q10	6261	1908	1642	1642
q11	448	262	236	236
q12	706	571	471	471
q13	18025	2914	2195	2195
q14	229	225	219	219
q15	q16	750	734	677	677
q17	732	835	455	455
q18	6122	5405	5228	5228
q19	1278	983	631	631
q20	540	486	379	379
q21	4377	1818	1412	1412
q22	342	296	242	242
Total cold run time: 94514 ms
Total hot run time: 26741 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	5038	4775	4608	4608
q2	q3	3870	4375	3825	3825
q4	903	1204	778	778
q5	4072	4402	4336	4336
q6	186	175	148	148
q7	1830	1683	1531	1531
q8	2527	2702	2552	2552
q9	7699	7080	7560	7080
q10	3760	4121	3609	3609
q11	513	426	421	421
q12	486	589	456	456
q13	2701	3253	2318	2318
q14	280	293	269	269
q15	q16	721	773	713	713
q17	1169	1376	1370	1370
q18	7427	6825	6691	6691
q19	953	889	948	889
q20	2064	2166	2017	2017
q21	3978	3469	3520	3469
q22	487	430	368	368
Total cold run time: 50664 ms
Total hot run time: 47448 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168834 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d48333a722afc2e09527997faa23bc1748136195, data reload: false

query5	4350	648	508	508
query6	342	229	217	217
query7	4238	485	270	270
query8	359	248	228	228
query9	8751	2679	2702	2679
query10	523	415	341	341
query11	6935	5112	4887	4887
query12	185	134	129	129
query13	1309	472	350	350
query14	5687	3727	3516	3516
query14_1	2879	2918	2850	2850
query15	212	197	180	180
query16	983	466	448	448
query17	902	741	626	626
query18	2465	457	361	361
query19	220	217	193	193
query20	134	128	128	128
query21	214	146	110	110
query22	13253	14107	14650	14107
query23	16327	15739	15614	15614
query23_1	15752	15587	15396	15396
query24	7060	1616	1221	1221
query24_1	1239	1233	1202	1202
query25	543	464	446	446
query26	1248	271	151	151
query27	2763	487	297	297
query28	4364	1860	1830	1830
query29	851	565	474	474
query30	297	222	188	188
query31	1026	946	888	888
query32	79	72	70	70
query33	509	337	297	297
query34	888	886	521	521
query35	648	677	601	601
query36	1081	1119	993	993
query37	129	94	83	83
query38	3003	2909	2906	2906
query39	855	835	819	819
query39_1	802	795	798	795
query40	236	156	172	156
query41	63	60	58	58
query42	265	252	253	252
query43	241	253	213	213
query44	
query45	200	190	184	184
query46	897	993	599	599
query47	2821	2552	2023	2023
query48	323	324	229	229
query49	656	462	391	391
query50	715	278	220	220
query51	4116	4111	3987	3987
query52	262	268	262	262
query53	289	331	283	283
query54	304	298	262	262
query55	94	86	90	86
query56	312	318	311	311
query57	1926	1729	1684	1684
query58	283	282	276	276
query59	2789	2932	2753	2753
query60	343	353	338	338
query61	158	156	155	155
query62	614	597	489	489
query63	308	272	280	272
query64	5027	1330	1017	1017
query65	
query66	1462	461	364	364
query67	24333	24289	24346	24289
query68	
query69	419	307	290	290
query70	986	963	979	963
query71	342	323	306	306
query72	3014	2924	2774	2774
query73	544	552	326	326
query74	9624	9572	9392	9392
query75	2883	2764	2457	2457
query76	2143	1031	673	673
query77	370	384	305	305
query78	10886	11192	10506	10506
query79	1115	767	575	575
query80	859	649	560	560
query81	499	258	223	223
query82	1274	157	117	117
query83	348	262	252	252
query84	300	119	101	101
query85	943	514	468	468
query86	408	308	299	299
query87	3169	3127	3038	3038
query88	3524	2662	2653	2653
query89	424	367	347	347
query90	1833	182	180	180
query91	174	167	143	143
query92	80	78	75	75
query93	923	847	499	499
query94	525	322	293	293
query95	598	411	325	325
query96	666	526	233	233
query97	2465	2500	2399	2399
query98	233	218	227	218
query99	999	967	925	925
Total cold run time: 249030 ms
Total hot run time: 168834 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (19782/37535)
Line Coverage 36.24% (184786/509899)
Region Coverage 32.47% (143004/440352)
Branch Coverage 33.66% (62537/185809)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.66% (26326/36738)
Line Coverage 54.48% (276880/508187)
Region Coverage 51.81% (230245/444398)
Branch Coverage 53.14% (99000/186291)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants