The CreateDSTesetExtension no longer requires a parent test class#145
Draft
The CreateDSTesetExtension no longer requires a parent test class#145
Conversation
The previous behavior of the extension required the use `AbstractLdapTestUnit` or duplicating static variables named `classDirectoryService`/`methodDirectoryService`
Now the directoryService can be injected into the test as a parameter, e.g.
void myTest( DirectoryService directoryService ) { ... }
A class level or method level DirectoryService will be injected automatically
NOTE: The previous behavior will still work to ensure backward compatiblity.
Member
Author
|
While creating a SCIMple + ApacheDS example, I ran into a few minor issues trying to use the extension without using NOTE: I only updated Also, do we care about the backward compatibility here? If not, I can cleanup the code a bit more (and still keep the functionality of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior of the extension required the use
AbstractLdapTestUnitor duplicating static variables namedclassDirectoryService/methodDirectoryServiceNow the directoryService can be injected into the test as a parameter, e.g.
void myTest( DirectoryService directoryService ) { ... }
A class level or method level DirectoryService will be injected automatically
NOTE: The previous behavior will still work to ensure backward compatiblity.