Fix panic in SET AUTHORIZATION parsing when scope modifier is missing
#2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Feb 7, 2026
Comment on lines
+14519
to
+14521
| ParserError::ParserError( | ||
| "Expected a scope modifier (e.g. SESSION) before AUTHORIZATION".to_string(), | ||
| ) |
Contributor
There was a problem hiding this comment.
can we use one of the helper functions like self.expected_at?
| fn test_set_authorization_without_scope_errors() { | ||
| // This should return a parser error, not panic. | ||
| let res = parse_sql_statements( | ||
| "\tSET\t\t\t\t\t\t\t\t\t\tAUTHORIZATION\tTIME\t\t\t\t\t\tTIME\u{fffd}\u{fffd}v\u{1}\0\0\t74843EUTI>\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0USER_RNCLUDE_NULL\0\0\0\0\0\0\0\0\0\t\t\t\t^^^^^^^^\tWHI\t\tIN" |
Contributor
There was a problem hiding this comment.
is there a simpler test case that reproduces the error? I'm assuming the escape sequences and null characters shouldnt be necessary based on the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing
SET AUTHORIZATION <value>without a scope modifier (e.g.SESSION,LOCAL) causes a panic due to an.expect()call on aNonevalue inparse_set. This was discovered via a fuzz-like input string but is trivially reproducible with anySET AUTHORIZATION ...statement that omits the scope keyword.The panic occurs at mod.rs:
Valid SQL requires a scope modifier, e.g.
SET SESSION AUTHORIZATION 'user', so the missing scope is indeed an error — but it should be a gracefulParserError, not a panic.Closes #2200