docs: expand tuning guide with performance and memory configs#4908
Open
andygrove wants to merge 1 commit into
Open
docs: expand tuning guide with performance and memory configs#4908andygrove wants to merge 1 commit into
andygrove wants to merge 1 commit into
Conversation
Audited all CometConf entries and added documentation for user-facing performance and memory knobs that were undocumented in the tuning guide: batch size, spill disk cap, Parquet parallel I/O and filter pushdown, Iceberg data-file concurrency, shuffle compression codec/level, row/columnar transition revert, and metrics overhead. Also fixed an incorrect claim about the default shuffle compression codec (LZ4, not ZSTD) and moved spark.comet.maxTempDirectorySize into the tuning category so it renders in the Memory & Tuning table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited all
CometConfentries in preparation for the 1.0 release and expanded the Tuning Guide with the user-facing performance and memory knobs that were previously undocumented.New sections in
tuning.md:spark.comet.batchSize(memory vs. throughput tradeoff) and its shuffle-writer cousinspark.comet.columnar.shuffle.batch.sizespark.comet.maxTempDirectorySize(100 GB default)spark.comet.scan.icebergNative.dataFileConcurrencyLimitspark.comet.exec.transitionRevert.{enabled,maxTransitions}spark.comet.metrics.enabledis off by defaultAlso:
lz4).spark.comet.maxTempDirectorySizefrom theexeccategory totuningso it renders in the Memory & Tuning table inconfigs.md, and expanded its doc string.Test plan
configs.mdstill generates cleanly (moved config appears in Memory & Tuning table)