feat: accelerate Iceberg RewriteDataFiles reads via Comet native scan#4251
Open
jordepic wants to merge 1 commit intoapache:mainfrom
Open
feat: accelerate Iceberg RewriteDataFiles reads via Comet native scan#4251jordepic wants to merge 1 commit intoapache:mainfrom
jordepic wants to merge 1 commit intoapache:mainfrom
Conversation
jordepic
force-pushed
the
main
branch
2 times, most recently
from
5b382c0 to
352861a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4250.
Rationale for this change
A large number of query resources are devoted across the industry to rewriting data files using spark procedures for iceberg tables. Using native code here where possible can significantly speed up this process!
What changes are included in this PR?
Detect spark scans (
SparkStagedScan) that are created during theRewriteDataFilesSparkActionand replace them with comet scans. Extract their associated tasks and pass in the lack of filter (see SparkStagedScan line 50 in the apache iceberg project).How are these changes tested?
We write two tests to inspect the spark plan associated with rewriting data files and ensure that the operators get replaced. Before this change is merged I can also try to run it locally and pick up some benchmarks for table compactions (on tables that are only data files, and those with delete files associated).