test: Add additional contains expression tests#3462
Merged
andygrove merged 1 commit intoapache:mainfrom Feb 10, 2026
Merged
Conversation
Add test coverage for null haystack, case sensitivity, and both-columns (array-array) path for the optimized contains implementation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
comphead
reviewed
Feb 10, 2026
| } | ||
| } | ||
|
|
||
| test("contains with both columns") { |
Contributor
There was a problem hiding this comment.
are you planning also move it to sql tests?
Member
Author
There was a problem hiding this comment.
maybe .. we have many, many tests to move over to the new approach. I guess we need to figure out a plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #2991.
Rationale for this change
The optimized
containsimplementation merged in #2991 had good test coverage but was missing a few edge cases.What changes are included in this PR?
Adds integration tests for:
contains(NULL, 'pattern')) to verify null propagationcontains(name, 'james')vs'James')contains(col1, col2)) exercising the array-array code path, including null in either positionHow are these changes tested?
All new tests use
checkSparkAnswerAndOperatorto verify both correctness against Spark and that Comet's native operator is used.🤖 Generated with Claude Code