perf: [iceberg] Single-pass FileScanTask validation#3443
Merged
mbutrovich merged 39 commits intoapache:mainfrom Feb 10, 2026
Merged
perf: [iceberg] Single-pass FileScanTask validation#3443mbutrovich merged 39 commits intoapache:mainfrom
mbutrovich merged 39 commits intoapache:mainfrom
Conversation
…oned columns) and run a representative test.
…er assertion in DPP test.
1. findAllIcebergSplitData() collected perPartitionByLocation (all partitions' data) 2. This map was captured in the createCometExecIter closure 3. ZippedPartitionsRDD serialized that closure to every task 4. Each task received ALL partitions' data (925 bytes to both tasks) Instead we now use CometIcebergSplitRDD which puts per-partition data in Partition objects.
…hat every partition doesn't come over.
… columns), fixes TestRuntimeFiltering Iceberg Java tests with column renames. CometIcebergSplitRDD registers subqueries so native code can look them up, fixes TestViews Iceberg Java tests with rewritten filter.
… assertion at index lookup, and defensive fallback if future Spark behavior changes.
# Conflicts: # .github/workflows/iceberg_spark_test.yml
# Conflicts: # spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala
# Conflicts: # spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We currently iterate through an Iceberg scan's
FileScanTasks three times to validate them. This adds overhead for large Iceberg table scans.What changes are included in this PR?
Collapse the three loops down to one.
How are these changes tested?
Existing tests, new benchmark for running CometScanRule.