chore!: bump minimum Node.js engine to >=14.17.0#154
Open
escoberik wants to merge 2 commits intoapache:masterfrom
Open
chore!: bump minimum Node.js engine to >=14.17.0#154escoberik wants to merge 2 commits intoapache:masterfrom
escoberik wants to merge 2 commits intoapache:masterfrom
Conversation
uuid <14.0.0 is flagged by GHSA-w5hq-g745-h8pq (missing buffer bounds check in v3/v5/v6 when buf is provided). The only upstream fix is uuid v14, but v14 dropped CommonJS support, which would break this package. Since only uuid.v4() is used here (in generateUuid()), replace it with Node's built-in crypto.randomUUID() — available since Node 14.17.0, produces the same RFC 4122 v4 UUID format, and requires no external dependency. The uuid package is removed from dependencies entirely. BREAKING CHANGE: Node >=14.17.0 is now required at runtime (crypto.randomUUID was introduced in that release). The engines field remains >=10.0.0; a separate PR will bump it to reflect the new minimum. All 426 existing tests pass.
Reflects the runtime requirement introduced by apache#153 (crypto.randomUUID, available since Node 14.17.0). Node 10 and 12 have been EOL since 2021 and 2022 respectively. BREAKING CHANGE: Node <14.17.0 is no longer supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #153.
crypto.randomUUID()— introduced to replace theuuiddependency in #153 — requires Node.js >=14.17.0. Node 10 and 12 have been EOL since 2021 and 2022 respectively.This is a separate PR as requested so that #153 can be reverted independently if needed.
Breaking change
Node <14.17.0 is no longer supported.