Prefill custom compute offering values for VMware import#13237
Open
andrijapanicsb wants to merge 1 commit into
Open
Prefill custom compute offering values for VMware import#13237andrijapanicsb wants to merge 1 commit into
andrijapanicsb wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13237 +/- ##
=========================================
Coverage 18.10% 18.10%
- Complexity 16746 16748 +2
=========================================
Files 6037 6037
Lines 542933 542945 +12
Branches 66487 66494 +7
=========================================
+ Hits 98283 98292 +9
- Misses 433602 433605 +3
Partials 11048 11048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
Author
|
@blueorangutan package |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0 MHz.Problem
When importing a VMware VM and selecting a custom unconstrained compute offering, the UI could prefill the custom fields with generic fallback values instead of the discovered source VM sizing:
10 MHz32 MBThis happened even when the source VM details already showed useful sizing information, for example
3 CPUand4096 MBmemory.Existing Behavior
serviceofferingdetailswith min/max CPU and memory bounds.1 CPU,0 MHz, and32 MB.New Behavior
0or unknown, the UI now defaults the custom CPU speed field to2000 MHz.Testing
git diff --check.ui/src/views/tools/ImportUnmanagedInstance.vue.