Additional metrics for virtual machine orchestration#13141
Additional metrics for virtual machine orchestration#13141sureshanaparti wants to merge 3 commits intoapache:4.22from
Conversation
Signed-off-by: Alakesh Haloi <a_haloi@apple.com>
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull request overview
This PR enhances observability around VM orchestration by expanding StatsCollector’s metrics exposure capabilities, including external registration and JMX visibility.
Changes:
- Exposes
METRIC_REGISTRYpublicly and adds a staticregisterMetric()helper for external metric registration. - Starts a Dropwizard
JmxReporterunder thevm-extraJMX domain for metrics visibility via JMX.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try { | ||
| JmxReporter.forRegistry(METRIC_REGISTRY).inDomain("vm-extra").build().start(); | ||
| } catch (Exception e) { | ||
| logger.warn("Failed to start JMX reporter for METRIC_REGISTRY, metrics will not be visible via JMX", e); | ||
| } |
| public static final MetricRegistry METRIC_REGISTRY = new MetricRegistry(); | ||
|
|
||
| public static void registerMetric(String name, Metric metric) { | ||
| METRIC_REGISTRY.register(name, metric); | ||
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13141 +/- ##
=========================================
Coverage 17.68% 17.68%
- Complexity 15790 15791 +1
=========================================
Files 5922 5922
Lines 533119 533127 +8
Branches 65201 65201
=========================================
+ Hits 94257 94260 +3
- Misses 428219 428224 +5
Partials 10643 10643
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17790 |
Description
This PR adds support for additional metrics for virtual machine orchestration.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?