Skip to content

Allow parallel execution of NAS backup and delete commands #12847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmsperu wants to merge 3 commits into
base: 4.20
Choose a base branch
from
+1 −1
Open

Allow parallel execution of NAS backup and delete commands #12847

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81f5dd2
Allow parallel execution of backup and delete commands
jmsperu Mar 17, 2026
b2cd0bf
fix(backup): restrict parallel execution to TakeBackup only
jmsperu May 22, 2026
4338c9c
ci: retrigger workflow (flaky/stale shards)
jmsperu May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/cloudstack/backup/TakeBackupCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,6 @@ public void setVolumePaths(List<String> volumePaths) {

@Override
public boolean executeInSequence() {
return true;
return false;
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmsperu is this relevant?

Copy link
Copy Markdown
Collaborator Author

@jmsperu jmsperu May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland yes — this is the change that allows the parallel execution the PR title describes. With executeInSequence returning true (the previous default for TakeBackupCommand), the KVM agent serialises any other backup commands behind it; a long-running snapshot copy would block a concurrent delete on a different VM's backup. Flipping it to false lets the agent dispatch DeleteBackupCommand immediately alongside an in-flight TakeBackupCommand, which is the whole point of #12847.

The safety case is bounded — the backup and delete operations target different on-NAS paths (each backup is named after its VM uuid + timestamp), so there's no path-level contention to worry about, and the NFS mount lifecycle is per-script-invocation, not shared. Happy to add an inline comment in TakeBackupCommand.java noting this if you'd like that documented at the class level.

}
}
Loading