UI: Fix api method to getAPI in SearchFilter.vue#12558
UI: Fix api method to getAPI in SearchFilter.vue#12558vishesh92 wants to merge 3 commits intoapache:4.22from
Conversation
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates API method calls in SearchFilter.vue from the deprecated api function to the new getAPI and postAPI functions, aligning with changes introduced in PR #10899 which adds support for enforcing POST requests on state-changing APIs.
Changes:
- Updated import statement to use
getAPIandpostAPIinstead ofapi - Replaced 4
api()calls with appropriategetAPI()orpostAPI()calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12558 +/- ##
============================================
- Coverage 17.62% 17.61% -0.01%
- Complexity 15664 15666 +2
============================================
Files 5915 5915
Lines 531144 531144
Branches 64930 64930
============================================
- Hits 93591 93587 -4
- Misses 427015 427021 +6
+ Partials 10538 10536 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
this does not look good in QA, checking to see if this is a 21 vs 22 issue. @blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16652 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16653 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@vishesh92 I think, I resolved these ui changes in forward merge, check and close this PR if not required anymore. |
Description
This PR fixes api calls in SearchFilter added in 4.20. The API methods were changed from api to getAPI & postAPI. This PR updates the same for
SearchFilter.vue.#10899
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?