CASSANDRA-21247: [trunk] Enable check_data_resurrection by default in cassandra_latest.yaml#4763
CASSANDRA-21247: [trunk] Enable check_data_resurrection by default in cassandra_latest.yaml#4763isaacreath wants to merge 1 commit intoapache:trunkfrom
Conversation
…ra_latest.yaml This patch updates the default value for check_data_resurrection so that users can benefit from this feature automatically in the next major release. patch by Isaac Reath; reviewed by Stefan Miklosovic, Paulo Motta for CASSANDRA-21247
isaacreath
changed the title
| # # Minimum grace period for the check, defaults to 0. Useful when gc_grace_seconds is very | ||
| # # small (e.g. 0) to avoid blocking startup immediately. | ||
| # minimum_threshold: 3h | ||
| minimum_threshold: 3h |
There was a problem hiding this comment.
Above comment says 'defaults to 0'. Is this change to set minimum_threshold to 3h intentional? But then all clusters across the world will default to this on upgrade. We should discuss this in dev community before changing the default.
There was a problem hiding this comment.
My impression from the ML thread regarding this change (https://lists.apache.org/thread/z3mdvw78f5cqovq781tvjm537w66cpsm) was that 3h would be a good default when enabling this feature so as to ensure that enabling this feature doesn't render nodes unstartable.
The comment is interesting because per this default in cassandra_latest.yaml, it is set to 3h, but in the code the default is set to 0 still (and if you remove this it is still set to 0).
There was a problem hiding this comment.
I updated the ML thread to see if there are any thoughts for an alternative minimum.
There was a problem hiding this comment.
I am fine as long as dev community is aware of this upcoming default change.
2 participants
This patch updates the default value for check_data_resurrection so that users can benefit from this feature automatically in the next major release.
patch by Isaac Reath; reviewed by Stefan Miklosovic, Paulo Motta for CASSANDRA-21247