[CASSANDRA-21295][trunk] Avoid unit conversion in DatabaseDescriptor.getMaxValueSize() for every deserializing Cell#4745
Open
netudima wants to merge 1 commit intoapache:trunkfrom
Open
Conversation
…ry deserializing Cell patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21295
frankgh
reviewed
Apr 23, 2026
| public IntMebibytesBound(String value) | ||
| { | ||
| super(value, MEBIBYTES, Integer.MAX_VALUE); | ||
| bytes = Ints.saturatedCast(unit().toBytes(quantity())); |
Contributor
There was a problem hiding this comment.
Should we do the same for other implementations of org.apache.cassandra.config.DataStorageSpec where we are doing Ints.saturatedCast operations?
Contributor
Author
There was a problem hiding this comment.
yes, it makes sense, while I've seen this issue only in the described use case, it may impact other scenarios I've not checked yet too, so I will apply it for other implementations
Contributor
There was a problem hiding this comment.
Yeah, also to be consistent across all implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unit conversion in DatabaseDescriptor.getMaxValueSize() for every deserializing Cell
patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21295