Skip to content

CAMEL-23812: camel-milo better username & password handling#24193

Merged
davsclaus merged 5 commits into
mainfrom
milo-better-user-password-handling
Jun 23, 2026
Merged

CAMEL-23812: camel-milo better username & password handling#24193
davsclaus merged 5 commits into
mainfrom
milo-better-user-password-handling

Conversation

@davsclaus

Copy link
Copy Markdown
Contributor

Summary

  • Adds explicit username and password options to MiloClientConfiguration so credentials no longer need to be embedded in the endpoint URI
  • Fixes issues with special characters in passwords (e.g. @, $, ?, %) that broke URI parsing and replaceFirst() regex matching
  • Rebuilds discovery URI from parsed URI parts instead of string manipulation
  • Includes regenerated metadata files (configurers, URI factories, JSON) that were missing from the original PR

Based on the work from @robMate in #24185, with regenerated metadata and formatting fixes added on top.

Test plan

  • ExplicitCredentialsTest added to verify explicit username/password handling
  • Build camel-milo module: cd components/camel-milo && mvn verify

Claude Code on behalf of Claus Ibsen

mattesKoerber and others added 5 commits June 22, 2026 11:49
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • catalog/camel-catalog
  • components/camel-milo
  • dsl/camel-componentdsl
  • dsl/camel-endpointdsl
All tested modules (11 modules)
  • Camel :: Catalog :: Camel Catalog
  • Camel :: Component DSL
  • Camel :: Endpoint DSL
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: Milo
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@davsclaus davsclaus merged commit 58f5ca7 into main Jun 23, 2026
6 checks passed
@davsclaus davsclaus deleted the milo-better-user-password-handling branch June 23, 2026 08:32
@robMate

robMate commented Jun 23, 2026

Copy link
Copy Markdown

Cool thank you for the quick resolution of this issue and for fixing up my code 😊👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants