Skip to content

Fix DoRead() returns error errno#3248

Open
chenBright wants to merge 1 commit intoapache:masterfrom
chenBright:setfailed_0
Open

Fix DoRead() returns error errno#3248
chenBright wants to merge 1 commit intoapache:masterfrom
chenBright:setfailed_0

Conversation

@chenBright
Copy link
Contributor

@chenBright chenBright commented Mar 24, 2026

What problem does this PR solve?

Issue Number:

Problem Summary:

In Socket::DoRead(), when an SSL read encounters a system error (the else branch), the PLOG_IF macro may overwrite errno during logging. Since the caller of DoRead depends on a correct errno, this can cause the caller to receive a corrupted error code, leading to incorrect error handling.

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects:

  • Breaking backward compatibility:


Check List:

@wwbmmm
Copy link
Contributor

wwbmmm commented Mar 24, 2026

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants