Skip to content

Comments

Don't verify wheels.#37671

Draft
tvalentyn wants to merge 2 commits intoapache:masterfrom
tvalentyn:wheel_specs
Draft

Don't verify wheels.#37671
tvalentyn wants to merge 2 commits intoapache:masterfrom
tvalentyn:wheel_specs

Conversation

@tvalentyn
Copy link
Contributor

fixes: #37670


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Python SDK installation process within the container by eliminating the need to verify wheel compatibility against specific Python versions or platform specifications. The change simplifies the logic for identifying the correct Apache Beam SDK wheel, making the installation more straightforward and less prone to issues related to environment-specific wheel naming conventions.

Highlights

  • Removed Wheel Verification Logic: The code responsible for determining and verifying acceptable Python wheel specifications (e.g., manylinux versions) has been entirely removed.
  • Simplified SDK Wheel Identification: The process for finding the Apache Beam SDK wheel has been simplified to directly identify any file starting with 'apache_beam' and ending with '.whl', without checking against specific acceptable wheel specs.
  • Code Cleanup: Unused imports and global variables related to the removed wheel verification logic have been cleaned up.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/container/boot.go
    • Removed the 'regexp' import as it was no longer needed.
    • Eliminated the 'acceptableWhlSpecs' global variable.
    • Deleted the 'setupAcceptableWheelSpecs' function, which previously determined acceptable wheel specifications based on the installed Python version.
    • Updated the 'installSetupPackages' function to remove the call to the now-deleted 'setupAcceptableWheelSpecs' and adjusted the arguments passed to 'installSdk'.
  • sdks/python/container/piputil.go
    • Refactored the 'findBeamSdkWhl' function to remove the 'acceptableWhlSpecs' parameter and simplify the wheel identification logic to check only for the 'apache_beam' prefix and '.whl' suffix.
    • Modified the 'installSdk' function to remove the 'acceptableWhlSpecs' parameter and adapt its call to the updated 'findBeamSdkWhl' function.
Activity
  • The pull request description includes standard contribution guidelines and CI status checks, but no specific human activity or review comments have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tvalentyn tvalentyn marked this pull request as draft February 21, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Beam's boot.go has restriction on Beam SDK whl format, which breaks precommit test

1 participant