Fix breaking changes from renaming Chunk to EmbeddableItem (#37651)

[claudevdm]

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses necessary adjustments following a previous rename of Chunk to EmbeddableItem. The primary focus is on maintaining API stability and providing a smooth transition for users by ensuring backward compatibility for configuration arguments in the BigQuery ingestion module. It also includes a minor update to a SQL query alias and a routine CI trigger file modification.

Highlights

• Backward Compatibility for SchemaConfig: The SchemaConfig class in bigquery.py was refactored from a dataclass to a standard class with an __init__ method. This change introduces backward compatibility for the chunk_to_dict_fn argument, now aliased to embeddable_to_dict_fn, and issues a DeprecationWarning when the old argument is used.
• SQL Query Alias Adjustment: In bigquery_vector_search.py, a SQL query alias was updated from embeddable_items to chunks within the VECTOR_SEARCH function, aligning with naming conventions.
• CI Trigger Update: A trivial modification was made to a GitHub Actions trigger file to ensure the associated test suite runs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .github/trigger_files/beam_PostCommit_Python_Xlang_Gcp_Direct.json
  • Incremented the modification field to trigger CI.
• sdks/python/apache_beam/ml/rag/enrichment/bigquery_vector_search.py
  • Updated the SQL alias from embeddable_items to chunks in the VECTOR_SEARCH query.
• sdks/python/apache_beam/ml/rag/ingestion/bigquery.py
  • Refactored SchemaConfig from a dataclass to a standard class with an __init__ method.
  • Introduced ChunkToDictFn as a backward-compatible alias for EmbeddableToDictFn.
  • Added logic to SchemaConfig.__init__ to handle chunk_to_dict_fn as a deprecated argument, mapping it to embeddable_to_dict_fn and issuing a DeprecationWarning.
  • Implemented validation to ensure embeddable_to_dict_fn is provided and to catch unexpected keyword arguments in SchemaConfig's constructor.

Activity

• The pull request was opened by claudevdm to fix breaking changes from renaming Chunk to EmbeddableItem.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claudevdm]

R: @damccorm

[claudevdm]

R: @Abacn

[damccorm]

Thanks!

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers