Go VR Flink test on Flink 2.0

[Abacn]

#37600

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Go SDK's Flink validation tests to align with Flink 2.0 by dynamically fetching the latest Flink version and introducing a robust mechanism for specifying pre-built Go Docker images during runner tests. These changes enhance the flexibility and maintainability of the testing infrastructure, ensuring compatibility with newer Flink versions and streamlining the testing workflow.

Highlights

• Flink Version Update: The Flink validates runner task now dynamically uses the latestFlinkVersion from project extensions instead of a hardcoded value, resolving a previously noted TODO item related to issue [Bug]: Go Validates Runner tests failing under Flink 2.0 #37600.
• Go Docker Image Tagging Mechanism: A new --prebuild_go_docker_tag argument has been introduced and integrated across various Go SDK runner validation tasks (Flink, Samza, Spark, ULR, Prism, Go IO) to allow specifying a pre-built Docker image tag for testing.
• Docker Build Integration: The Go SDK container build process (sdks/go/container/build.gradle) was enhanced to support custom Docker tags, and the sparkValidatesRunner task now explicitly depends on the Go container Docker build to ensure the image is available.
• Test Script Argument Handling: The run_validatesrunner_tests.sh script was updated to parse and utilize the new --prebuild_go_docker_tag argument, adjusting the Docker image selection logic to prioritize this tag if provided.
• CI Trigger File Cleanup: An outdated comment related to Flink 1.19 support was removed from the .github/trigger_files/beam_PostCommit_Go_VR_Flink.json file, tidying up the configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .github/trigger_files/beam_PostCommit_Go_VR_Flink.json
  • Removed an outdated comment regarding Flink 1.19 support.
• sdks/go/container/build.gradle
  • Modified the containerImageName function to accept a tag parameter, enabling custom Docker image tagging.
• sdks/go/test/build.gradle
  • Updated the flinkValidatesRunner task to use project.ext.latestFlinkVersion instead of a hardcoded value.
  • Added --prebuild_go_docker_tag to several runner validation tasks (Flink, Samza, Spark, ULR, Prism, Go IO).
  • Added a dependency on the Go container Docker build for sparkValidatesRunner.
• sdks/go/test/run_validatesrunner_tests.sh
  • Replaced the --java11_home argument with --prebuild_go_docker_tag.
  • Adjusted the Docker image tagging logic to prioritize the pre-built tag if provided.

Activity

• The pull request description indicates that issue [Bug]: Go Validates Runner tests failing under Flink 2.0 #37600 is related to this change.
• The PR description includes boilerplate text for contributing, but no specific human activity or review comments are provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Abacn]

To reproduce,

GOCMD=/usr/local/go/bin/go. # Or your go bin path
./gradlew :sdks:go:test:flinkValidatesRunner -x flinkValidatesRunner  # run all dependency tasks
cd sdks/go/test
./run_validatesrunner_tests.sh --runner flink --flink_job_server_jar ./run_validatesrunner_tests.sh --runner flink \
--flink_job_server_jar <path to beam>/beam/runners/flink/2.0/job-server/build/libs/beam-runners-flink-2.0-job-server-2.72.0-SNAPSHOT.jar \
--prebuild_go_docker_tag 2.72.0.dev --pipeline_opts '--expansion_jar=test:<path to beam>/beam/sdks/java/testing/expansion-service/build/libs/beam-sdks-java-testing-expansion-service-testExpansionService-2.72.0-SNAPSHOT.jar' \
--tests ./test/integration/primitives --run TestTimers_EventTime_Bounded

List of failing tests:

TestMongoDBIO_Read/Read_documents_from_MongoDB_with_id_of_type_primitive.ObjectID (71.57s)
TestMongoDBIO_Read/Read_documents_from_MongoDB_with_id_of_type_string (18.90s)
TestMongoDBIO_Read/Read_documents_from_MongoDB_where_filter_matches (18.98s)
TestMongoDBIO_Read/Read_documents_from_MongoDB_with_bucketAuto_aggregation (10.99s)
TestTimers_EventTime_Bounded (11.20s)
TestTimers_EventTime_WithNoOutputTimestamp (12.65s)
TestLPErrorReshufflePipeline_PAssert (8.36s)
TestLPErrorReshufflePipeline_SideInput (7.87s)
TestLPErrorReshufflePipeline_DoFnPAssert (8.09s)
TestLPErrorReshufflePipeline_DoFnSideInput (7.95s)