ARTEMIS-6031 Handle credit starvation affecting Core bridge#6387
Open
AntonRoskvist wants to merge 1 commit intoapache:mainfrom
Open
ARTEMIS-6031 Handle credit starvation affecting Core bridge#6387AntonRoskvist wants to merge 1 commit intoapache:mainfrom
AntonRoskvist wants to merge 1 commit intoapache:mainfrom
Conversation
jbertram
reviewed
Apr 28, 2026
| return null; | ||
| }).when(mockClientSession).sendProducerCreditsMessage(Mockito.anyInt(), Mockito.any()); | ||
|
|
||
| AsynchronousProducerCreditsImpl producerCredits = new AsynchronousProducerCreditsImpl(mockClientSession, null, producerWindowSize, bridgeFlowCallback(blocked)); |
Contributor
There was a problem hiding this comment.
Instead of having the private static method I think this is a bit more clear:
AsynchronousProducerCreditsImpl producerCredits = new AsynchronousProducerCreditsImpl(mockClientSession, null, producerWindowSize, new ClientProducerFlowCallback() {
@Override
public void onCreditsFlow(boolean isBlocked, ClientProducerCredits credits) {
blocked.set(isBlocked);
}
@Override
public void onCreditsFail(ClientProducerCredits credits) {
}
});
jbertram
reviewed
Apr 28, 2026
| } | ||
| } else { | ||
| if (logger.isTraceEnabled()) { | ||
| logger.trace("CheckCredits did not need it, balance={}, arriving={}, needed={}, getbalance + arriving < needed={}", getBalance(), arriving, needed, (boolean)(getBalance() + arriving < needed)); |
Contributor
There was a problem hiding this comment.
This log message should be updated to reflect the new comparison logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #6020
The fix in that case is still valid but turns out there was a similar thing that could happen in
AbstractProducerCreditsImplas well.Big thanks to @mbengtsson for co-authoring this PR!