GH-50225: [Ruby] Move merge implementation to ColumnContainable#50226
Open
Reranko05 wants to merge 1 commit into
Open
GH-50225: [Ruby] Move merge implementation to ColumnContainable#50226Reranko05 wants to merge 1 commit into
Reranko05 wants to merge 1 commit into
Conversation
|
|
kou
reviewed
Jun 19, 2026
Comment on lines
+86
to
+90
| record_batch = self.class.new( | ||
| Schema.new(fields), | ||
| n_rows, | ||
| arrays, | ||
| ) |
Member
There was a problem hiding this comment.
If we can use RecordBatch.new(fields, arrays), can we unify this code?
If so, let's accept RecordBatch.new(fields, arrays).
Contributor
Author
There was a problem hiding this comment.
I investigated using RecordBatch.new(Schema.new(fields), arrays) to unify this code, but it uses the RecordBatchBuilder path and fails for the merged arrays. It looks like RecordBatch.new(schema, n_rows, arrays) is required here, so I kept the current implementation.
If you have any other way in mind to unify this code, let me know.
github-actions
Bot
added
awaiting changes
Reranko05
force-pushed
the
column-containable-merge-refactor
branch
from
32bc7e4 to
cef651f
Compare
github-actions
Bot
added
awaiting change review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow::Table#mergeandArrow::RecordBatch#mergehad similar implementations, resulting in duplicated merge logic.What changes are included in this PR?
This PR moves the common merge implementation to
Arrow::ColumnContainable.Container-specific behavior such as column conversion and creating the merged container remains implemented in
Arrow::TableandArrow::RecordBatch.Are these changes tested?
Yes.
The existing
RecordBatchandTabletest suites were run and passed successfully.Are there any user-facing changes?
No.