GH-50219: [R] Fix duckdb test for dbplyr 2.6.0#50220
Open
thisisnic wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
awaiting committer review
Member
Author
|
@github-actions crossbow submit test-r-depsource-system test-r-gcc-11 test-r-gcc-12 test-r-m1-san test-r-offline-maximal test-r-versions |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an R test failure caused by dbplyr 2.6.0 changing how remote_con() retrieves the connection from a tbl.
Changes:
- Update the DuckDB integration test to override
ds_rt$con(instead ofds_rt$src$con) so the simulated “non-DuckDB connection” path still triggers the expectedto_arrow()error withdbplyr2.6.0.
|
Revision: a468619 Submitted crossbow builds: ursacomputing/crossbow @ actions-74af3d833c
|
thisisnic
commented
Jun 18, 2026
| # Now check errors | ||
| # dbplyr 2.6.0 added "con" to the allowed $ fields on tbl_lazy; | ||
| # older versions only allow "src" and "lazy_query" | ||
| skip_if(packageVersion("dbplyr") < "2.6.0") |
Member
Author
There was a problem hiding this comment.
Needs skipping or fails on CI with cached dbplyr with old syntax
github-actions
Bot
added
awaiting review
github-actions
Bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
dbplyr 2.6.0 changed
remote_con()to read fromx$coninstead ofx$src$con. The duckdb test that simulates a non-DuckDB connection was overriding the old path, so the expected error was no longer thrown.What changes are included in this PR?
Update the test to override
ds_rt$coninstead ofds_rt$src$con.Are these changes tested?
This is a test fix — the test itself verifies the behavior.
Are there any user-facing changes?
No.