Skip to content

MINOR: [Dev][CI] Install libuv1-dev in dev.yml lint step for R fs package#49791

Merged
amoeba merged 1 commit intoapache:mainfrom
amoeba:minor/dev-yaml-libuv
Apr 18, 2026
Merged

MINOR: [Dev][CI] Install libuv1-dev in dev.yml lint step for R fs package#49791
amoeba merged 1 commit intoapache:mainfrom
amoeba:minor/dev-yaml-libuv

Conversation

@amoeba
Copy link
Copy Markdown
Member

@amoeba amoeba commented Apr 18, 2026

Rationale for this change

Pre-commit in CI just started to fail trying to install the R fs package. See https://github.com/apache/arrow/actions/runs/24610839359.

I think we didn't see this until now because we were using cached pre-commit and a recent PR of mine just invalidated the cache incidentally. See also #49594. The fs package recently made a change that requires we install libuv development headers to install it.

What changes are included in this PR?

  • Updates dev.yml to Install libuv1-dev

Are these changes tested?

Yes. See my other PR: #49788 (comment).

Are there any user-facing changes?

No.

Copy link
Copy Markdown
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 18, 2026
@amoeba amoeba merged commit 70f8c20 into apache:main Apr 18, 2026
9 checks passed
@amoeba amoeba removed the awaiting merge Awaiting merge label Apr 18, 2026
@amoeba
Copy link
Copy Markdown
Member Author

amoeba commented Apr 18, 2026

Merged, thanks for the quick approval!

@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 70f8c20.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants