GH-32381: [C++] Improve error handling for hash table merges#49512
Open
kris-gaudel wants to merge 4 commits intoapache:mainfrom
Open
GH-32381: [C++] Improve error handling for hash table merges#49512kris-gaudel wants to merge 4 commits intoapache:mainfrom
kris-gaudel wants to merge 4 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
zanmato1984
reviewed
Mar 15, 2026
Contributor
zanmato1984
left a comment
There was a problem hiding this comment.
Thanks — the fix direction looks right to me overall, but I think there are two follow-ups worth addressing inline.
7b7f298 to
bdcacb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #32381
What changes are included in this PR?
Proper error handling in
util/hashing.hand unit test for said error handling inutil/hashing_test.ccAre these changes tested?
Yes, via included unit test
Are there any user-facing changes?
Yes, error handling in hashing utilities