GH-49266: [C++][Parquet] Optimize delta bit-packed decoding when bit-width = 0#49296
Open
pitrou wants to merge 1 commit intoapache:mainfrom
Open
GH-49266: [C++][Parquet] Optimize delta bit-packed decoding when bit-width = 0#49296pitrou wants to merge 1 commit intoapache:mainfrom
pitrou wants to merge 1 commit intoapache:mainfrom
Conversation
3e048a6 to
ec8c4a3
Compare
Member
Author
|
FTR @AntoinePrv :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DELTA_BINARY_PACKED decoding has limited performance due to a back-to-back dependency between the computations of value N and value N+1.
However, we can do better if we know that all deltas are 0 in a miniblock. This happens when a miniblock's delta bit width.
What changes are included in this PR?
Avoid reading and accumulating deltas when we the delta bit width is 0. Instead, use a condensed formula that allows to compute a value without waiting for the previous one.
Benchmark results on constant ranges of integers (on my local machine, AMD Zen 2 CPU):
Are these changes tested?
Yes, by an additional test meant to stress this specific situation.
Are there any user-facing changes?
No.