MINOR: [C++] Remove obsolete TODO comment from mode kernel registration#49122
Merged
thisisnic merged 1 commit intoapache:mainfrom Apr 21, 2026
Merged
Conversation
HyukjinKwon
changed the title
HyukjinKwon
force-pushed
the
minor-remove-orphaned-todo
branch
from
eb0323a to
83eac4a
Compare
thisisnic
approved these changes
Apr 21, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 00a30c6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The TODO comment was added in commit 53752ad during the ExecSpan refactoring. It was, presumably, a reminder to migrate the mode kernel from the old
GenerateNumericOldAPI to the newGenerateNumericAPI. This migration was completed in commit 4d931ff, but the TODO comment was accidentally left behind.What changes are included in this PR?
Removed the orphaned
// TODO(wesm):comment fromaggregate_mode.cc. The work it referenced was completed.Are these changes tested?
No, I did not test.
Are there any user-facing changes?
No.