Fix Dataflow deferrable trigger handling of transient 503#66293
Merged
shahar1 merged 3 commits intoapache:mainfrom May 5, 2026
Merged
Fix Dataflow deferrable trigger handling of transient 503#66293shahar1 merged 3 commits intoapache:mainfrom
shahar1 merged 3 commits intoapache:mainfrom
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
eladkal
reviewed
May 4, 2026
Contributor
|
cc @VladaZakharova can you review? |
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #57359
How to reproduce
Using
test_run_continues_polling_after_retryable_service_unavailabletemplate_job_start_trigger.run()callsget_job_status(), which is mocked to raiseServiceUnavailablefor a transient Dataflow API 503.TriggerEventimmediately instead of sleeping and polling again.How to fix
Catch
ServiceUnavailableinside the Dataflow job-status polling loop, sleep forpoll_sleep, and continue polling.Tests
Was generative AI tooling used to co-author this PR?
Generated-by: Codex 5.5 following the guidelines