Reduce HostRegexTableLoadBalancer RPCs for OOB checks#6446
Merged
Conversation
The StatusThread.updateStatus() method in the Manager calls gatherTableInformation to get information about all of the TabletServers in the cluster, then calls balanceTablets(). balanceTablets() creates a partitioned view of the status information and uses that when creating the BalanceParams to pass to table balancer's balance(). The HostRegexTableLoadBalancer.balance method will periodically check for tablets that are hosted outside of the definied regex. Prior to this change it was making an RPC call to every tablet server outside of the defined regex. This change uses the gathered tablet server information such that the RPC call is made to the tablet server if the information indicates that the tablet server is hosting tablets for the table. The RPC is necessary to get the extent information to create the migrations, but it's only necessary when the tablet server is hosting tablets for the table.
FineAndDandy
approved these changes
Jun 25, 2026
ivakegg
approved these changes
Jun 25, 2026
avgAGB
approved these changes
Jun 25, 2026
DomGarguilo
approved these changes
Jun 25, 2026
dlmarion
added a commit
that referenced
this pull request
Jun 26, 2026
The StatusThread.updateStatus() method in the Manager calls gatherTableInformation to get information about all of the TabletServers in the cluster, then calls balanceTablets(). balanceTablets() creates a partitioned view of the status information and uses that when creating the BalanceParams to pass to table balancer's balance(). The HostRegexTableLoadBalancer.balance method will periodically check for tablets that are hosted outside of the defined regex. Prior to this change it was making an RPC call to every tablet server outside of the defined regex. This change uses the gathered tablet server information such that the RPC call is made to the tablet server if the information indicates that the tablet server is hosting tablets for the table. The RPC is necessary to get the extent information to create the migrations, but it's only necessary when the tablet server is hosting tablets for the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StatusThread.updateStatus() method in the Manager calls gatherTableInformation to get information about all of the TabletServers in the cluster, then calls balanceTablets().
balanceTablets() creates a partitioned view of the status information and uses that when creating the BalanceParams to pass to table balancer's balance().
The HostRegexTableLoadBalancer.balance method will periodically check for tablets that are hosted outside of the defined regex. Prior to this change it was making an RPC call to every tablet server outside of the defined regex.
This change uses the gathered tablet server information such that the RPC call is made to the tablet server if the information indicates that the tablet server is hosting tablets for the table. The RPC is necessary to get the extent information to create the migrations, but it's only necessary when the tablet server is hosting tablets for the table.