fix: inject Skill into --tools when skills are enabled and tools is explicit#1045
Open
ashishpatel26 wants to merge 1 commit into
Open
Conversation
…xplicit (anthropics#977) When tools was set explicitly (e.g. tools=['Bash', 'Read']) alongside skills='all', the Skill runner was added to --allowedTools but not to --tools. The CLI's --tools flag overrides --allowedTools, leaving Skill unavailable. Now Skill is injected into the tools list too when skills is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
toolsis set explicitly (e.g.tools=['Bash', 'Read']) alongsideskills='all', theSkillrunner was added to--allowedToolsbut not to--tools. Because the CLI's--toolsflag overrides--allowedTools, the Skill tool was effectively unavailable at runtime.skillsis set andtoolsis an explicit list in_build_command"Skill"into the tools list if not already presentskills="all", named skills, and the case where"Skill"is already presentTest plan
test_skills_all_injects_skill_into_explicit_tools_listtest_named_skills_inject_skill_into_explicit_tools_listtest_skill_already_in_tools_not_duplicatedpython -m pytest tests/test_transport.py -vFixes #977