fix: raise RateLimitError on HTTP 429 instead of crashing#1044
Open
ashishpatel26 wants to merge 1 commit into
Open
fix: raise RateLimitError on HTTP 429 instead of crashing#1044ashishpatel26 wants to merge 1 commit into
ashishpatel26 wants to merge 1 commit into
Conversation
…#812) Add a typed RateLimitError exception so callers can catch rate-limit failures separately from other errors. The read loop detects 429/ rate-limit text in the error and routes it through the new type rather than a generic Exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #812
When the Anthropic API returns HTTP 429, the SDK surfaced a generic uncaught exception with no actionable type. This PR adds a typed
RateLimitErrorso callers can catch and handle rate-limit failures separately.Changes Made
src/claude_agent_sdk/_errors.py: addRateLimitError(ClaudeSDKError)with optionalretry_after: intfieldsrc/claude_agent_sdk/_internal/query.py: add_is_rate_limit_error()helper; detect 429/rate-limit text in the error path and raiseRateLimitErrorinstead of a genericExceptionsrc/claude_agent_sdk/__init__.py: exportRateLimitErrortests/test_errors.py: 18 tests covering subclassing,retry_after, and all_is_rate_limit_errordetection patternsUsage After This Fix
Testing
tests/test_errors.pyRelated Issue
Closes #812