fix(task): surface non-text subagent results#29176
Open
smithyyang wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24447
Type of change
What does this PR do?
This fixes the
tasktool returning an empty<task_result>when a subagent completes without a finaltextpart.Before this change,
TaskToolonly looked for the lasttextpart and fell back to""if none existed. That made reasoning-only or non-text child completions look like blank results in the parent session.This change keeps the existing behavior when a child returns text, and otherwise returns a short diagnostic summary with the finish reason, error, and emitted part types.
How did you verify your code works?
bun run typecheckinpackages/opencodebun test test/tool/task.test.ts --test-name-pattern "execute returns child text output when present|execute returns diagnostic output when child finishes without a text part"bun test test/cli/run/entry.body.test.ts test/cli/run/scrollback.surface.test.tsScreenshots / recordings
Not a UI change.
Checklist