fix(workspaces): surface session directory filter state in list dialog#29172
Open
jamesmurdza wants to merge 1 commit into
Open
fix(workspaces): surface session directory filter state in list dialog#29172jamesmurdza wants to merge 1 commit into
jamesmurdza wants to merge 1 commit into
Conversation
The session list silently filters to the current workspace's directory when the filter is enabled, with no UI indication of why sessions are missing. The existing toggle is buried in the command palette under `app.toggle.session_directory_filter` with no default keybind. - Show the filter state in the dialog title: `Sessions · current directory` vs `Sessions · all directories`. - Add a dialog-scoped action `session.list.toggle_filter` bound to `<leader>f` so users can flip the filter without leaving the list. The footer label flips between `show all` and `filter to dir` to match the action it will take. - Let dialog-select actions opt out of requiring a selected row (`requireSelection: false`) so the toggle works even when the filter has emptied the list — the exact case this feature addresses. The default of `session_directory_filter_enabled = true` is preserved — only the visibility and reachability change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: James Murdza <james@jamesmurdza.com>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Looking at the search results, I found one potentially related PR: PR #29026: This PR is related because it addresses session list filtering based on directory scope — the same underlying feature that PR #29172 is surfacing in the UI. If PR #29026 is still open or recently merged, it could overlap with the changes in the current PR. All other results either don't match the specific functionality or are the current PR itself (#29172). Would you like me to check the status of PR #29026 to confirm if there's a conflict or overlap? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27286
Type of change
What does this PR do?
When inside a workspace, the session list is silently filtered to that workspace's sessions, with no indication it's happening — so users lose track of sessions they know exist. The only toggle lives in the command palette (
app.toggle.session_directory_filter) with no default keybind, so users can't tell that filtering is on, that a toggle exists, or how to reach it.This surfaces the filter and makes it toggleable from the session list itself:
Sessions · current directoryvsSessions · all directories.show allandfilter to dir), bound to<leader>fso it's reachable without the palette.The default (
session_directory_filter_enabled = true) is unchanged — only the visibility and reachability of the existing filter change.How did you verify your code works?
Manually, in the TUI, against a build of this branch:
The title reads
Sessions · current directory, and the footer shows the toggle asshow all ctrl+x f.Press
<leader>f(ctrl+x f):Sessions · all directories.filter to dir.This confirms the filter state is now visible and the toggle is reachable and updates live.
Screenshots / recordings
Checklist