Skip to content

feat(desktop): pass through ADAL_APP_URL to sidecar for token compression #29158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chindris-mihai-alexandru wants to merge 1 commit into from
+22 −0
Closed

feat(desktop): pass through ADAL_APP_URL to sidecar for token compression #29158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/desktop/src-tauri/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,28 @@ pub fn spawn_command(
state_dir.to_string_lossy().to_string(),
),
];

// Pass through token compression proxy URL to the sidecar process.
// When ADAL_APP_URL is set, the sidecar routes LLM requests through
// the specified proxy for transparent compression or middleware.
// Only localhost/loopback URLs are accepted to prevent unintended
// traffic routing to external endpoints.
if let Some(app_url) = std::env::var_os("ADAL_APP_URL") {
if let Some(url_str) = app_url.to_str() {
if url_str.starts_with("http://localhost")
|| url_str.starts_with("http://127.0.0.1")
|| url_str.starts_with("http://[::1]")
{
envs.push(("ADAL_APP_URL".to_string(), url_str.to_string()));
} else {
tracing::warn!(
url = %url_str,
"Ignoring ADAL_APP_URL: only localhost URLs are permitted"
);
}
}
}
Comment on lines +392 to +411
Copy link
Copy Markdown
Author

@chindris-mihai-alexandru chindris-mihai-alexandru May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Addressed in force-push. Now validates that only localhost/loopback URLs are accepted:

if url_str.starts_with("http://localhost")
    || url_str.starts_with("http://127.0.0.1")
    || url_str.starts_with("http://[::1]")

Non-local URLs are rejected with tracing::warn. This prevents any env injection from routing sensitive traffic externally.

HTTPS enforcement was considered but intentionally omitted — localhost proxies typically run plain HTTP (TLS adds complexity for loopback with no security benefit since traffic never leaves the machine).


envs.extend(
extra_env
.iter()
Expand Down
Loading