fix(shell): ensure standard PATH directories on macOS#29093
Open
divitkashyap wants to merge 1 commit into
Open
fix(shell): ensure standard PATH directories on macOS#29093divitkashyap wants to merge 1 commit into
divitkashyap wants to merge 1 commit into
Conversation
On macOS, the shell tool may launch with an incomplete PATH that does not include /opt/homebrew/bin, causing common commands like git and gh to fail with 'env: sh: No such file or directory'. Prepend the standard macOS PATH directories (/opt/homebrew/bin, /usr/local/bin, /usr/bin, /bin) to the shell environment when they are missing, matching what a user's interactive shell would see. Refs anomalyco#17792
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17792
Type of change
What does this PR do?
On macOS, the shell tool can launch with an incomplete `PATH` that omits `/opt/homebrew/bin` (and sometimes `/usr/local/bin`). When that happens, calls like `git` or `gh` from the agent fail with `env: sh: No such file or directory`, even though those binaries are on the user's interactive `PATH`.
Prepend the standard macOS directories (`/opt/homebrew/bin`, `/usr/local/bin`, `/usr/bin`, `/bin`) to the shell env when they are missing. darwin-only; no-op when paths are already present.
This is a partial mitigation for #17792 — it doesn't fully unify with the user's interactive shell, but it removes the most common failure mode (Homebrew binaries unreachable from the agent). Happy for a maintainer to reopen the broader issue after merge if a full shell-init unification is still wanted.
How did you verify your code works?
Logic check against the existing `shellEnv` builder in `packages/opencode/src/tool/shell.ts` — the change only appends to the env that's already constructed from `process.env` + plugin extras.
Checklist
Supersedes #21347 (auto-closed by cleanup); bash tool was renamed to `shell.ts` so the fix has been re-targeted.