Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/opencode/src/session/prompt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,10 @@ export const layer = Layer.effect(
sessionID,
mode: task.agent,
agent: task.agent,
variant: lastUser.model.variant,
variant:
taskModel.providerID === lastUser.model.providerID && taskModel.id === lastUser.model.modelID
? lastUser.model.variant
: undefined,
path: { cwd: ctx.directory, root: ctx.worktree },
cost: 0,
tokens: { input: 0, output: 0, reasoning: 0, cache: { read: 0, write: 0 } },
Expand Down Expand Up @@ -704,7 +707,7 @@ export const layer = Layer.effect(
.get(),
)
const model = input.model ?? ag.model ?? (yield* currentModel(input.sessionID))
const same = ag.model && model.providerID === ag.model.providerID && model.modelID === ag.model.modelID
const same = !ag.model || (model.providerID === ag.model.providerID && model.modelID === ag.model.modelID)
const full =
!input.variant && ag.variant && same
? yield* provider
Expand Down
9 changes: 7 additions & 2 deletions packages/opencode/src/tool/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,11 @@ export const TaskTool = Tool.define(

const msg = yield* MessageV2.get({ sessionID: ctx.sessionID, messageID: ctx.messageID }).pipe(Effect.orDie)
if (msg.info.role !== "assistant") return yield* Effect.fail(new Error("Not an assistant message"))
const parentAssistant = msg.info

const model = next.model ?? {
modelID: msg.info.modelID,
providerID: msg.info.providerID,
modelID: parentAssistant.modelID,
providerID: parentAssistant.providerID,
}
const metadata = {
parentSessionId: ctx.sessionID,
Expand Down Expand Up @@ -201,6 +202,10 @@ export const TaskTool = Tool.define(
providerID: model.providerID,
},
agent: next.name,
variant:
!next.variant && model.providerID === parentAssistant.providerID && model.modelID === parentAssistant.modelID
? parentAssistant.variant
: undefined,
tools: {
...(next.permission.some((rule) => rule.permission === "todowrite") ? {} : { todowrite: false }),
...(next.permission.some((rule) => rule.permission === id) ? {} : { task: false }),
Expand Down
132 changes: 131 additions & 1 deletion packages/opencode/test/session/prompt.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { SystemPrompt } from "../../src/session/system"
import { Shell } from "../../src/shell/shell"
import { Snapshot } from "../../src/snapshot"
import { ToolRegistry } from "@/tool/registry"
import type { Tool } from "@/tool/tool"
import { Truncate } from "@/tool/truncate"
import * as Log from "@opencode-ai/core/util/log"
import { CrossSpawnSpawner } from "@opencode-ai/core/cross-spawn-spawner"
Expand Down Expand Up @@ -985,7 +986,7 @@ noLLMServer.instance(
const registry = yield* ToolRegistry.Service
const { task } = yield* registry.named()
const original = task.execute
task.execute = (_args, ctx) =>
task.execute = (_args: unknown, ctx: Tool.Context) =>
Effect.callback<never>((_resume) => {
ctx.abort.addEventListener("abort", () => succeedVoid(aborted), { once: true })
if (ctx.abort.aborted) succeedVoid(aborted)
Expand Down Expand Up @@ -2227,6 +2228,135 @@ noLLMServer.instance(
},
)

noLLMServer.instance(
"applies agent variant to inherited model when supported",
() =>
Effect.gen(function* () {
const prompt = yield* SessionPrompt.Service
const sessions = yield* Session.Service
const session = yield* sessions.create({})

const result = yield* prompt.prompt({
sessionID: session.id,
agent: "build",
noReply: true,
parts: [{ type: "text", text: "hello" }],
})

if (result.info.role !== "user") throw new Error("expected user message")
expect(result.info.model).toEqual({
providerID: ProviderID.make("test"),
modelID: ModelID.make("test-model"),
variant: "xhigh",
})
}),
{
config: {
...cfg,
provider: {
...cfg.provider,
test: {
...cfg.provider.test,
models: {
"test-model": {
...cfg.provider.test.models["test-model"],
variants: { xhigh: {}, high: {} },
},
},
},
},
agent: {
build: {
variant: "xhigh",
},
},
model: "test/test-model",
},
},
)

it.instance(
"subtask explicit different model does not copy parent variant",
() =>
Effect.gen(function* () {
const { llm } = yield* useServerConfig((url) => ({
...providerCfg(url),
provider: {
...providerCfg(url).provider,
other: {
...cfg.provider.test,
id: "other",
name: "Other",
models: {
"other-model": {
...cfg.provider.test.models["test-model"],
id: "other-model",
name: "Other Model",
},
},
},
},
}))
const registry = yield* ToolRegistry.Service
const sessions = yield* Session.Service
const { task } = yield* registry.named()
const original = task.execute
task.execute = (_args: unknown, ctx: Tool.Context) =>
Effect.gen(function* () {
const message = yield* MessageV2.get({ sessionID: ctx.sessionID, messageID: ctx.messageID }).pipe(Effect.orDie)
expect(message.info.role).toBe("assistant")
if (message.info.role !== "assistant") return yield* Effect.die("expected assistant message")
expect(message.info.modelID).toBe(ModelID.make("other-model"))
expect(message.info.providerID).toBe(ProviderID.make("other"))
expect(message.info.variant).toBeUndefined()
return {
title: "inspect bug",
output: "done",
metadata: {
parentSessionId: ctx.sessionID,
sessionId: ctx.sessionID,
model: {
providerID: message.info.providerID,
modelID: message.info.modelID,
},
},
}
})
yield* Effect.addFinalizer(() => Effect.sync(() => void (task.execute = original)))

const { prompt, chat } = yield* boot()
const parent = yield* sessions.updateMessage({
id: MessageID.ascending(),
role: "user",
sessionID: chat.id,
agent: "build",
model: { ...ref, variant: "xhigh" },
time: { created: Date.now() },
})
yield* sessions.updatePart({
id: PartID.ascending(),
messageID: parent.id,
sessionID: chat.id,
type: "subtask",
prompt: "look into the cache key path",
description: "inspect bug",
agent: "general",
model: { providerID: ProviderID.make("other"), modelID: ModelID.make("other-model") },
})

yield* llm.text("done")
const result = yield* prompt.loop({ sessionID: chat.id })
expect(result.info.role).toBe("assistant")

const messages = yield* MessageV2.filterCompactedEffect(chat.id)
const taskMessage = messages.find(
(message) => message.info.role === "assistant" && message.info.agent === "general",
)
expect(taskMessage?.info.role).toBe("assistant")
if (taskMessage?.info.role === "assistant") expect(taskMessage.info.variant).toBeUndefined()
}),
)

// Agent / command resolution errors

noLLMServer.instance(
Expand Down
Loading
Loading