feat(review): show GitHub PR review comments inline#18990
Open
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Open
feat(review): show GitHub PR review comments inline#18990Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18964
Type of change
What does this PR do?
This PR adds read-only GitHub PR review comments to the Desktop review panel.
Before this change, the review panel could render local inline comments, but it had no way to fetch and show existing GitHub review comments for the current PR. That meant users still had to switch back to GitHub to see reviewer feedback next to the relevant diff.
This change adds a small VCS endpoint to fetch review comments for the PR associated with the current branch, maps GitHub review comment positions into the same file/line selection model already used by the review UI, and then renders those comments inline in the existing review panel.
I kept GitHub comments read-only on purpose. Local editable comments still work the same way as before, and this PR does not try to handle posting/replying/resolving review comments.
Why this works:
How did you verify your code works?
I verified it by:
cd packages/sdk/js && bun ./script/build.tscd packages/opencode && bun typecheckcd packages/app && bun typecheckcd packages/ui && bun typecheckcd packages/sdk/js && bun typecheckbun turbo typecheckAll of those completed successfully locally.
Screenshots / recordings
I do not have a screenshot/recording attached yet. The UI change is limited to showing GitHub PR review comments inline in the existing review panel.
Checklist