fix(app): auto-register direct-route projects#18947
Open
wxt365 wants to merge 3 commits intoanomalyco:devfrom
Open
fix(app): auto-register direct-route projects#18947wxt365 wants to merge 3 commits intoanomalyco:devfrom
wxt365 wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
|
a70eb2a to
5401b5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18943
Type of change
What does this PR do?
Opening a valid
/:dir/...route resolved the directory context, but it did not register the project in the sidebar.This PR triggers the existing project-open flow after the direct-route directory is resolved, so direct routing behaves the same as manually opening a project.
The change is small and reuses the existing idempotent
layout.projects.open()path, which already loads sessions and avoids duplicate sidebar entries.How did you verify your code works?
cd packages/app && bun test --preload ./happydom.ts ./src/pages/directory-layout.test.tscd packages/app && bun testScreenshots / recordings
Attach a short recording showing that opening
/{base64(directory)}/sessionmakes the project appear in the sidebar automatically.Checklist