fix(app): avoid false follow-up queue after session becomes idle#18944
Open
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): avoid false follow-up queue after session becomes idle#18944Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18713
Type of change
What does this PR do?
This fixes a follow-up queue bug in the app session page.
Before this change, follow-up queueing used a broader
busy()check that looked at both:session_statustime.completedThat created a short mismatch window where the session had already become
idle, the UI looked finished, but the assistant completion metadata had not synced yet. In that case, a new prompt could be incorrectly queued instead of being sent immediately.This patch narrows the queue decision to the authoritative
session_statussignal:queue, do not queuesession_status.type !== "idle", keep queue mode activeidle, do not queue even if assistant completion metadata is still laggingThe existing
busy()logic is still kept for the other session flows that already depend on it, so this change only affects the false-positive queue decision.I also added regression tests for:
idle + pending assistant completion-> should not queuebusy/retry-> should still queueHow did you verify your code works?
Tested locally with:
bun test src/pages/session/helpers.test.tsbun typecheckbun turbo typecheckThe new regression tests cover the queue decision directly.
Screenshots / recordings
N/A — this is a behavior fix for follow-up queueing, not a visual UI change.
Checklist