fix: cap active tools for providers with tool count limits#18916
Open
Svtter wants to merge 2 commits intoanomalyco:devfrom
Open
fix: cap active tools for providers with tool count limits#18916Svtter wants to merge 2 commits intoanomalyco:devfrom
Svtter wants to merge 2 commits intoanomalyco:devfrom
Conversation
Some providers (e.g. xAI) enforce undocumented tool count limits. Add limit.tools to model schema and cap activeTools in streamText when the total exceeds the provider limit, prioritizing built-in tools over MCP tools.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #17405
Split from #18635
Type of change
What does this PR do?
This PR contains the tool-limit work split out from #18635.
It includes:
limit.toolstools: 0values instead of treating them as missingThese changes are intended to reduce oversized tool payloads for providers like xAI/Grok that fail when too many tools are exposed in one turn.
How did you verify your code works?
cd packages/opencode && bun typecheckcd packages/opencode && bun test test/provider/provider.test.tsScreenshots / recordings
N/A - backend/provider behavior, no UI changes.
Checklist