fix(keybind): handle sticky leader modifiers#12573
Open
d-init-d wants to merge 1 commit intoanomalyco:devfrom
Open
fix(keybind): handle sticky leader modifiers#12573d-init-d wants to merge 1 commit intoanomalyco:devfrom
d-init-d wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Some terminals emit Ctrl combinations as control bytes (e.g.
\x07), and users often keep Ctrl held after pressing a leader chord (e.g.ctrl+xtheng). This combination can cause the second key to be missed even though the chord intent is clear.How
Keybind.fromParsedKey()(1..26 =>ctrl+a..z,0x1F=>ctrl+_), while intentionally skipping ambiguous codes (tab/enter/backspace/etc).Tests
cd packages/opencode && bun test test/keybind.test.tscd packages/opencode && bun run typecheckFixes #10444