Skip to content

Comments

feat(acp): expose subagents in available modes response#12563

Open
YichenLi00 wants to merge 1 commit intoanomalyco:devfrom
YichenLi00:feat/acp-expose-subagents
Open

feat(acp): expose subagents in available modes response#12563
YichenLi00 wants to merge 1 commit intoanomalyco:devfrom
YichenLi00:feat/acp-expose-subagents

Conversation

@YichenLi00
Copy link

Summary

Expose subagents in ACP available modes response for client-side access.

Closes #11576

Problem

ACP clients (e.g., agent-shell for Emacs) cannot access subagent information through ACP. Users need this to @mention specific subagents.

Solution

  • Add optional mode field to ModeOption type
  • Remove server-side subagent filter
  • Clients can filter by mode field if they only want primary agents

Changes

- type ModeOption = { id: string; name: string; description?: string }
+ type ModeOption = { id: string; name: string; description?: string; mode?: string }
- .filter((agent) => agent.mode !== "subagent" && !agent.hidden)
+ .filter((agent) => !agent.hidden)
  .map((agent) => ({
    id: agent.name,
    name: agent.name,
    description: agent.description,
+   mode: agent.mode,
  }))

Backward Compatibility

Existing clients continue to work. The mode field is optional and only adds information.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@YichenLi00 YichenLi00 force-pushed the feat/acp-expose-subagents branch from 434c91f to e1feb5b Compare February 7, 2026 03:55
- Add optional mode field to ModeOption type
- Remove subagent filter, let clients decide visibility
- Enables ACP clients to access subagent info for @mentions
@YichenLi00
Copy link
Author

@rekram1-node Fixed the issues from #12305:

  1. Added mode field to ModeOption type
  2. Why expose subagents: ACP clients like Emacs agent-shell need this for @mentions. Server shouldn't decide visibility - clients can filter by mode field if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Support subagent information in ACP

1 participant