Skip to content

Stop failing the build on low/moderate NuGet audit advisories #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angularsen merged 1 commit into from
May 2, 2026
+20 −4
Merged

Stop failing the build on low/moderate NuGet audit advisories #1660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions CodeGen/CodeGen.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,18 @@
<TargetFramework>net10.0</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<!-- Allow compile with various nullability warnings until fixed. -->
<WarningsNotAsErrors>8600,8601,8603,8604,8618,8619,8625</WarningsNotAsErrors>
<!--
Inherits Directory.Build.props codes and adds nullability warnings the codegen sources
have not been annotated for. All stay visible as warnings.
CS8600 - null literal to non-nullable
CS8601 - possible null reference assignment
CS8603 - possible null reference return
CS8604 - possible null reference argument
CS8618 - non-nullable field uninitialized in ctor
CS8619 - nullability mismatch
CS8625 - null literal to non-nullable reference
-->
<WarningsNotAsErrors>$(WarningsNotAsErrors);8600;8601;8603;8604;8618;8619;8625</WarningsNotAsErrors>
</PropertyGroup>

<ItemGroup>
Expand Down
10 changes: 8 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,14 @@
<PropertyGroup>
<!-- Warning instead of compile error on obsolete errors.-->
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- 612: obsolete, 618: obsolete with message -->
<WarningsNotAsErrors>612,618</WarningsNotAsErrors>
<!--
Warnings stay visible but do not fail the build. NU1903 (high) and NU1904 (critical) still fail.
CS0612 - obsolete member
CS0618 - obsolete member with message
NU1901 - NuGet audit: low severity vulnerability
NU1902 - NuGet audit: moderate severity vulnerability
-->
<WarningsNotAsErrors>612;618;NU1901;NU1902</WarningsNotAsErrors>
</PropertyGroup>

<!-- Build symbol package (.snupkg) to distribute the PDB file for debugging, in addition to Source Link per recommendation: https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink -->
Expand Down
Loading