Stuff#3809
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request modifies .ng-dev/config.mjs to inline various configuration exports instead of importing them from separate files, and introduces a temporary debug console.log statement. The review feedback correctly requests the removal of the debug statement and points out that the mergeMode configuration contains an invalid value, providing a suggestion to correct it to 'team-only'.
| console.log("just testing something out"); | ||
| export const github = {owner:'angular',name:'dev-infra',mainBranchName:'main',mergeMode:'all'}; |
There was a problem hiding this comment.
Remove the debug console.log statement and correct the mergeMode value. The mergeMode configuration must be one of the valid RepositoryMergeMode values: 'team-only' or 'caretaker-only'.
| console.log("just testing something out"); | |
| export const github = {owner:'angular',name:'dev-infra',mainBranchName:'main',mergeMode:'all'}; | |
| export const github = {owner:'angular',name:'dev-infra',mainBranchName:'main',mergeMode:'team-only'}; |
No description provided.