Skip to content

Stuff#3809

Closed
rigbyhaxer wants to merge 1 commit into
angular:mainfrom
rigbyhaxer:feature/stuff
Closed

Stuff#3809
rigbyhaxer wants to merge 1 commit into
angular:mainfrom
rigbyhaxer:feature/stuff

Conversation

@rigbyhaxer

Copy link
Copy Markdown

No description provided.

@google-cla

google-cla Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies .ng-dev/config.mjs to inline various configuration exports instead of importing them from separate files, and introduces a temporary debug console.log statement. The review feedback correctly requests the removal of the debug statement and points out that the mergeMode configuration contains an invalid value, providing a suggestion to correct it to 'team-only'.

Comment thread .ng-dev/config.mjs
Comment on lines +1 to +2
console.log("just testing something out");
export const github = {owner:'angular',name:'dev-infra',mainBranchName:'main',mergeMode:'all'};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Remove the debug console.log statement and correct the mergeMode value. The mergeMode configuration must be one of the valid RepositoryMergeMode values: 'team-only' or 'caretaker-only'.

Suggested change
console.log("just testing something out");
export const github = {owner:'angular',name:'dev-infra',mainBranchName:'main',mergeMode:'all'};
export const github = {owner:'angular',name:'dev-infra',mainBranchName:'main',mergeMode:'team-only'};

@rigbyhaxer rigbyhaxer closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant