Skip to content

fix(github-actions): restore "This" prefix in lock-bot message#3695

Merged
alan-agius4 merged 2 commits into
angular:mainfrom
erkamyaman:fix-lockbot-leading-this-word
May 21, 2026
Merged

fix(github-actions): restore "This" prefix in lock-bot message#3695
alan-agius4 merged 2 commits into
angular:mainfrom
erkamyaman:fix-lockbot-leading-this-word

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

@erkamyaman erkamyaman commented May 21, 2026

#3693 dropped the leading "This " from the lock-bot message, so it now reads "Issue has been..." / "Pull request has been..." instead of "This issue has been...". Restore the prefix so the wording matches angular/angular#68848 and the pre-#3693 message.

Refs #3693
Refs angular/angular#68848

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the automated lock message for issues and pull requests in the getLockMessage function to use a more natural phrasing. I have no feedback to provide as there were no review comments.

@erkamyaman erkamyaman force-pushed the fix-lockbot-leading-this-word branch from 50d5968 to f6faa8e Compare May 21, 2026 18:45
@erkamyaman
Copy link
Copy Markdown
Contributor Author

@alan-agius4 since you were on #3693, flagging this small follow-up. Restores the leading "This" in the lock-bot message.

@erkamyaman erkamyaman force-pushed the fix-lockbot-leading-this-word branch from f6faa8e to c78c63f Compare May 21, 2026 19:01
angular#3693 dropped the leading "This " from the lock-bot message, so it now opens with "Issue has been..." or "Pull request has been..." instead of "This issue has been...". This also no longer matches the wording asked for in angular/angular#68848. Restore the "This " prefix so both branches read naturally and match the original request.

Refs angular#3693, angular/angular#68848
@erkamyaman erkamyaman force-pushed the fix-lockbot-leading-this-word branch from c78c63f to 475199a Compare May 21, 2026 19:08
@alan-agius4
Copy link
Copy Markdown
Contributor

Thanks @erkamyaman

@erkamyaman
Copy link
Copy Markdown
Contributor Author

Thanks @erkamyaman

Pleasure is all mine! but DevInfra CI's failing on main_test with a bundled main.js mismatch. Any tip on regenerating it properly?

@alan-agius4
Copy link
Copy Markdown
Contributor

I believe it’s

pnpm bazel run //.github/local-actions/lock-closed:main

@alan-agius4
Copy link
Copy Markdown
Contributor

@erkamyaman, if you don’t manage I can do it for you.

@erkamyaman
Copy link
Copy Markdown
Contributor Author

@erkamyaman, if you don’t manage I can do it for you.

I would appreciate it so much, thank you

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 21, 2026
@alan-agius4 alan-agius4 merged commit 6f4b785 into angular:main May 21, 2026
12 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@erkamyaman erkamyaman deleted the fix-lockbot-leading-this-word branch May 21, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants