Skip to content

perf(@angular/build): dispose builder result context early in non-watch mode #33436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Jun 23, 2026
+7 −1
Merged

perf(@angular/build): dispose builder result context early in non-watch mode #33436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/angular/build/src/builders/application/build-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,13 @@ export async function* runEsBuildBuildAction(
// Output the first build results after setting up the watcher to ensure that any code executed
// higher in the iterator call stack will trigger the watcher. This is particularly relevant for
// unit tests which execute the builder and modify the file system programmatically.
yield* emitOutputResults(result, outputOptions);
const outputResults = [...emitOutputResults(result, outputOptions)];
if (!watch) {
await result.dispose();
// Set to true to prevent double-disposal of the result context in the finally block on generator exit
watchLoopStarted = true;
}
Comment thread
clydin marked this conversation as resolved.
yield* outputResults;

// Finish if watch mode is not enabled
if (!watcher) {
Expand Down
Loading