Skip to content

build: lock file maintenance#33433

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33431
Jun 23, 2026
Merged

build: lock file maintenance#33433
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33431

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

See associated pull request for more information.

Closes #33431 as a pr takeover

See associated pull request for more information.

Closes angular#33431 as a pr takeover
@alan-agius4 alan-agius4 requested a review from clydin June 23, 2026 09:12
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jun 23, 2026
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves TypeScript type safety in the Vitest runner plugins for the Angular build builder. It introduces explicit types from vitest/node (such as Vite.PluginOption, Vite.UserConfig, VitestPluginContext, and Vite.ViteDevServer) to various configurations, function parameters, and variables, and removes an unnecessary eslint-disable-next-line comment and type assertion. I have no feedback to provide.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2026
@alan-agius4 alan-agius4 merged commit b5db5f7 into angular:main Jun 23, 2026
70 of 71 checks passed
@alan-agius4 alan-agius4 deleted the pr-takeover-33431 branch June 23, 2026 16:06
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants