Skip to content

build: update babel monorepo to v8#33418

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33416
Jun 23, 2026
Merged

build: update babel monorepo to v8#33418
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33416

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

See associated pull request for more information.

Closes #33416 as a pr takeover

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Jun 19, 2026
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 19, 2026
@alan-agius4 alan-agius4 force-pushed the pr-takeover-33416 branch 3 times, most recently from 60f3f95 to 2ede90f Compare June 19, 2026 09:49
@alan-agius4 alan-agius4 requested a review from clydin June 19, 2026 09:49
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 19, 2026
@alan-agius4 alan-agius4 marked this pull request as ready for review June 19, 2026 09:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades Babel dependencies to version 8 across the workspace, updating type imports (such as using 'PluginObject' instead of 'PluginObj') and removing deprecated configuration options like 'bugfixes' and 'useESModules'. The feedback highlights a critical compatibility issue with Babel 8: raw object plugins are no longer supported and will cause runtime crashes. Instead of using unsafe type assertions, the reviewer recommends wrapping these plugin objects in factory functions (arrow functions) to ensure compatibility and type safety.

Comment thread packages/angular/build/src/tools/esbuild/i18n-inliner-worker.ts
Comment thread packages/angular_devkit/build_angular/src/utils/process-bundle.ts
Comment thread packages/angular_devkit/build_angular/src/utils/process-bundle.ts
See associated pull request for more information.

Closes angular#33416 as a pr takeover
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 22, 2026
@alan-agius4 alan-agius4 merged commit 316cc20 into angular:main Jun 23, 2026
39 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the pr-takeover-33416 branch June 23, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants