refactor(@angular/cli): restrict MCP host process spawning to Angular CLI executable#33132
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
refactor(@angular/cli): restrict MCP host process spawning to Angular CLI executable#33132clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
clydin
force-pushed
the
refactor/mcp-host-ng-restriction
branch
from
78a278f to
352e6d4
Compare
clydin
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Host interface by renaming runCommand to executeNgCommand and spawn to startNgProcess, while removing the redundant command parameter as these methods now specifically target the Angular CLI. These changes are consistently applied across the devserver, build, e2e, and test tools, as well as their mock implementations and unit tests. Feedback identifies that the options parameters in the createRootRestrictedHost implementation are typed too narrowly, which may cause properties like timeout, stdio, or env to be inaccessible or lost when delegating to the base host.
clydin
force-pushed
the
refactor/mcp-host-ng-restriction
branch
from
352e6d4 to
edde1be
Compare
… CLI executable Update the Host abstraction inside the Model Context Protocol (MCP) layer to tighten the system shell surface and improve semantics. The generic spawn and execute methods are replaced with specialized counterparts that default to the Angular CLI, enabling stronger path security containment for developers while also clarifying the distinct control flows needed for buffered discrete commands and long-running background services.
clydin
force-pushed
the
refactor/mcp-host-ng-restriction
branch
from
edde1be to
e1aaddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Host abstraction inside the Model Context Protocol (MCP) layer to tighten the system shell surface and improve semantics. The generic spawn and execute methods are replaced with specialized counterparts that default to the Angular CLI, enabling stronger path security containment for developers while also clarifying the distinct control flows needed for buffered discrete commands and long-running background services.