fix(@angular/build): remove default for unit-test coverage option#32805
Merged
clydin merged 1 commit intoangular:mainfrom Mar 20, 2026
Merged
fix(@angular/build): remove default for unit-test coverage option#32805clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where the default false value for the coverage option in the unit-test builder schema would override coverage settings from a runner's configuration file (e.g., vitest.config.ts). By removing the default, the option can be undefined, allowing the runner's configuration to be respected. The description for the coverage option has also been helpfully updated to clarify this new behavior. The change is well-justified and properly implemented.
Removing the default value of `false` for the `coverage` schema option in the
unit-test builder. When a default was present, it forced the coverage check in
the Vitest plugins to override any user-provided `coverage: { enabled: true }`
values set within a custom `vitest.config.ts`.
Removing the default explicitly allows the option to be `undefined`, respecting
the fallback behavior of the runner configuration.
The description was also updated to explicitly document how the Vitest runner
resolves the coverage configuration when the builder flag is omitted.
clydin
force-pushed
the
vitest/coverage-option-merging
branch
from
7165324 to
4ab650f
Compare
clydin
added
the
action: review
alan-agius4
added
action: merge
1 task
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the default value of
falsefor thecoverageschema option in the unit-test builder. When a default was present, it forced the coverage check in the Vitest plugins to override any user-providedcoverage: { enabled: true }values set within a customvitest.config.ts.Removing the default explicitly allows the option to be
undefined, respecting the fallback behavior of the runner configuration.The description was also updated to explicitly document how the Vitest runner resolves the coverage configuration when the builder flag is omitted.